-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cody Web: Support directory as initial context #5297
Conversation
@@ -104,7 +104,7 @@ export default defineProjectWithDefaults(__dirname, { | |||
assetsDir: '.', | |||
reportCompressedSize: true, | |||
lib: { | |||
formats: ['cjs'], | |||
formats: ['es'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is needed to unblock the svelte Cody Web update.
@@ -10,7 +10,7 @@ | |||
}, | |||
"main": "dist/index.js", | |||
"types": "dist/lib/index.d.ts", | |||
"sideEffects": false, | |||
"sideEffects": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for the proper bundle process on the Sourcegrpah side. When we target to es modules when we bundle/build Cody Web library it's important to specify this that compiler and minifier on Sourcegraph side won't remove unused es imports in Cody Web web-worker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please link this PR when you create one for SG.
Part of SRCH-940
See the original issue; in the Sourcegraph repo page, it's a common case when you open Cody Web chat from the directory page, so it makes sense to support directories as an initial mention for the chat.
Test plan